Address Verification Adjustments

[cassidysymons]

The soft launch revealed some edge cases in both the address verification and address adjustment pieces that needed adjustment, along with supporting pieces that needed improvement:

• We've added AV14 as a good code, provided there are no other errors
• Address_3 has been removed from the duplicate checking function, as it was added for Spain and is not relevant to any planned or foreseeable functionality
• The way in which address_2 is handled for duplicate checking has been refined, as None/null values were causing certain records to be ignored erroneously
• Unit tests for MelissaRepo did not exist but have been added
• The send_email event for invalid addresses was not being logged, but is now

[wasade]

This statement reads: if not good ... then say we're good. Is that correct? If so then that's a bit confusing :)

If r_good_conditional is also set in the if code in GOOD_CODES, then I think this could be changed too:

if r_good_conditional:
    if not r_errors_present:
        r_good = True

[cassidysymons]

It's essentially an alternative path to reaching a state of r_good = True. It could be simplified to just if r_good_conditional and not r_errors_present: but that has the potential to redundantly set r_good = True (which doesn't hurt anything, just feels a bit silly). I don't have strong feelings on the stylistic approach, I just wrote it to be abundantly clear that it's a conditional path to reaching a state of r_good = True since we're treating the code in GOOD_CODES_NO_ERROR differently than the ones in GOOD_CODES.

[wasade]

Makes sense. But my worry is looking back at this code a year from now, when something urgent is going on, where it's valuable to minimize the amount of time it takes to understand a conditional. If the concern is a redundant setting on r_good then that may be expressable as a comment. Sound reasonable?

[cassidysymons]

Definitely, will adjust in a few minutes.

[cassidysymons]

Adjusted and passing Lint now, let me know if there's anything else you'd like me to address before merging. Thanks!

[wasade]

Thanks! I'm +1