Image localization #135
Merged
Image localization #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…go into es_mx. Updated links to be replaced by babel in jinja2
|
Note that FAQ was deleted rather than translated |
wasade
approved these changes
May 10, 2021
| @@ -19,16 +19,16 @@ | |||
| {% block content %} | |||
| <div class="row"> | |||
| <div class="col-12 col-lg-8 text-center how_it_works"> | |||
| <img src="/static/img/how-it-works.svg" class="img-fluid" /> | |||
| <img src="/static/img/{{ _("en_us") }}/how-it-works.svg" class="img-fluid" /> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses babel updates in jinja2 templates to point towards correctly localized image files.
Assumes we will translate en_us to es_mx for our mexico deployment, and copy over translated images to that folder.
Only the bristol stool chart seems to be used within surveys, which is the only one I couldn't do this way. I added a separate PR to microsetta-private-api to update the sql on that side, but we may want to build more localization support on the private api side before merging that, or merge it to somewhere other than master.