Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to support proper function and testing of code in qp-klp. #110

Merged
merged 10 commits into from
Nov 14, 2023
Merged

Updates to support proper function and testing of code in qp-klp. #110

merged 10 commits into from
Nov 14, 2023

Conversation

charles-cowart
Copy link
Collaborator

No description provided.

@coveralls
Copy link

coveralls commented Nov 1, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6856512817

  • 61 of 96 (63.54%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.6%) to 82.83%
Changes Missing Coverage Covered Lines Changed/Added Lines %
sequence_processing_pipeline/scripts/cli.py 1 2 50.0%
sequence_processing_pipeline/Commands.py 4 9 44.44%
sequence_processing_pipeline/NuQCJob.py 12 41 29.27%
Files with Coverage Reduction New Missed Lines %
sequence_processing_pipeline/NuQCJob.py 1 56.33%
Totals Coverage Status
Change from base Build 6632678122: -0.6%
Covered Lines: 2107
Relevant Lines: 2408
💛 - Coveralls

@charles-cowart
WIP Updates based on testing w/qp-klp
4492b9d 
Needs an additional test for the fastp_reports migration.
@charles-cowart
Updates based on testing
b40e672
@charles-cowart charles-cowart mentioned this pull request Nov 8, 2023
Merged
@charles-cowart charles-cowart changed the title WIP: Updates to support proper function and testing of code in qp-klp. Updates to support proper function and testing of code in qp-klp. Nov 8, 2023
antgonza
antgonza approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@antgonza antgonza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a small question/suggestion.

sequence_processing_pipeline/NuQCJob.py Outdated Show resolved Hide resolved
@charles-cowart
Updates based on testing on qiita-rc
531ee2f
@charles-cowart
Corrects error in HTML and JSON file moves
1b3650b 
For runs with multiple projects, all html and json files would be copied
to a single project's subdirectories. This fix makes it so each html and
json files is moved to it's proper location.
@charles-cowart
Copy link
Collaborator Author

@antgonza Thank you for the review! Testing on qiita-rc with the latest change was successful. Please feel free to merge at your convenience!

antgonza
antgonza approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@antgonza antgonza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @wasade and @charles-cowart.

@antgonza antgonza merged commit 0297979 into biocore:master Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wasade wasade wasade left review comments

@antgonza antgonza antgonza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@charles-cowart @coveralls @wasade @antgonza