Update _bp.pyx #28
Merged
Update _bp.pyx #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing some method definitions from cdef to cpdef so we have access to those methods from python
|
👍 Looks like travis isn't running -- I'll see what's going on there |
|
Thanks for that merge. Travis is running again, looks like there are some issues (https://travis-ci.com/github/wasade/improved-octo-waddle/jobs/363453203). I think it's just that the |
|
was hopeful py37 would work but it doesn't due to dependencies (https://travis-ci.com/github/wasade/improved-octo-waddle/jobs/363457462). Can you remove the py37 entry from .travis.yml? that i think should do it |
|
Thanks! Travis is happy now.
… On Jul 21, 2020, at 12:04 PM, Daniel McDonald ***@***.***> wrote:
was hopeful py37 would work but it doesn't due to dependencies (https://travis-ci.com/github/wasade/improved-octo-waddle/jobs/363457462 <https://urldefense.com/v3/__https://travis-ci.com/github/wasade/improved-octo-waddle/jobs/363457462__;!!Mih3wA!V7rBu4m8tHJhAdQ2246ABMVTPX6PBkmF8dbNCveU77wSycr-4ELJGITw6CuDR0a6$>). Can you remove the py37 entry from .travis.yml? that i think should do it
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <https://urldefense.com/v3/__https://github.com/wasade/improved-octo-waddle/pull/28*issuecomment-662049935__;Iw!!Mih3wA!V7rBu4m8tHJhAdQ2246ABMVTPX6PBkmF8dbNCveU77wSycr-4ELJGITw6OGzX8Nw$>, or unsubscribe <https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ABRPHIKGWPUT5JB7XVR3Q4DR4XREJANCNFSM4PD3RY3Q__;!!Mih3wA!V7rBu4m8tHJhAdQ2246ABMVTPX6PBkmF8dbNCveU77wSycr-4ELJGITw6CFnNtcy$>.
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing some method definitions from cdef to cpdef, so we have access to those methods from python