-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some fixes ( <-- most original/descriptive title... ) #593
Conversation
@@ -1017,7 +1017,7 @@ def check_recipe_skippable(recipe, check_channels): | |||
# No packages with same version + build num in channels: no need to skip | |||
return False | |||
num_new_pkg_builds = Counter( | |||
(meta.name(), meta.version(), int(meta.build_number()) or 0, _meta_subdir(meta)) | |||
(meta.name(), meta.version(), int(meta.build_number() or 0), _meta_subdir(meta)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixes error in https://circleci.com/gh/bioconda/bioconda-recipes/65938:
...
File "/Users/distiller/project/miniconda/lib/python3.6/site-packages/bioconda_utils/utils.py", line 1021, in <genexpr>
for meta in metas
ValueError: invalid literal for int() with base 10: ''
Exited with code 1
@@ -261,7 +261,7 @@ def build_recipes(recipe_folder: str, config_path: str, recipes: List[str], | |||
|
|||
# setup linting | |||
if do_lint: | |||
always_exclude = ('build_number_needs_bump') | |||
always_exclude = ('build_number_needs_bump',) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes error in https://circleci.com/gh/bioconda/bioconda-recipes/65883:
13:32:21 BIOCONDA INFO Linting recipe recipes/pylibseq
13:32:21 BIOCONDA ERROR Skipping unknown check s
13:32:21 BIOCONDA ERROR Skipping unknown check m
13:32:21 BIOCONDA ERROR Skipping unknown check n
13:32:21 BIOCONDA ERROR Skipping unknown check e
13:32:21 BIOCONDA ERROR Skipping unknown check p
13:32:21 BIOCONDA ERROR Skipping unknown check d
13:32:21 BIOCONDA ERROR Skipping unknown check _
13:32:21 BIOCONDA ERROR Skipping unknown check i
13:32:21 BIOCONDA ERROR Skipping unknown check b
13:32:21 BIOCONDA ERROR Skipping unknown check u
13:32:21 BIOCONDA ERROR Skipping unknown check l
13:32:21 BIOCONDA ERROR Skipping unknown check r
13:32:21 BIOCONDA ERROR
set("build_number_needs_bump") == set("smnepd_ibulr")
;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks... that was my bug I think
This is an intermitted failure that I saw once before last week. Meh, if it happens too often, I might be forced to inverstigate :/ .... |
Ready to review/merge. |
👍 LGTM |
Thanks! |
Couple of small fixes.
Update to
conda-build=3.18.9
to get conda/conda-build#3621 in. (run_exports
-related, see conda/conda-build#3617 and linked issues for details)