Build kmer-jellyfish for other platforms #51683
Conversation
|
Warning Rate limit exceeded@mencian has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 0 minutes and 32 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📝 Walkthrough📝 Walkthrough📝 Walkthrough📝 Walkthrough📝 Walkthrough📝 Walkthrough📝 Walkthrough📝 Walkthrough📝 Walkthrough📝 Walkthrough📝 Walkthrough📝 Walkthrough📝 Walkthrough📝 WalkthroughWalkthroughThe changes in this pull request involve modifications to the Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- recipes/kmer-jellyfish/meta.yaml (3 hunks)
🔇 Additional comments (3)
recipes/kmer-jellyfish/meta.yaml (3)
23-25: Review Python dependencies configurationA few concerns about the dependencies:
- The Python version constraint was removed from requirements but added as a skip directive. Consider keeping both for clarity.
- setuptools might not be needed as a runtime dependency unless it's explicitly imported.
Let's verify if setuptools is actually needed at runtime:
#!/bin/bash # Check if any Python files import setuptools rg -l "import setuptools|from setuptools" # Check if setup.py uses setuptools for runtime features rg -l "pkg_resources"Also applies to: 27-28
40-40: Verify license file pathThe license file path needs verification to ensure it matches the actual file in the source distribution.
#!/bin/bash # Extract the tarball and verify license file URL=$(rg -o 'url: (.+)' meta.yaml | cut -d' ' -f2) WORKDIR=$(mktemp -d) curl -sSL $URL | tar xz -C $WORKDIR ls -la $WORKDIR/jellyfish-2.3.1/LICENSE*
46-47: Verify platform compatibilityWhile adding platform support, we should verify:
- No platform-specific code would break the build
- All required dependencies support these platforms
#!/bin/bash # Check for platform-specific code or compiler directives rg -l "ifdef.*__aarch64__|ifdef.*__arm64__" # Check for assembly files that might need platform support fd -e asm -e S
| number: 4 | ||
| skip: True # [py < 38] |
There was a problem hiding this comment.
💡 Codebase verification
Version is correct, but platform support needs attention
The version 2.3.1 is verified to be the latest release from the upstream repository. However, the recipe lacks explicit platform configurations for both linux-aarch64 and osx-arm64. To properly enable cross-platform support as mentioned in the PR objectives, you should:
- Add platform configurations for both linux-aarch64 and osx-arm64
- Consider using
skip: False # [aarch64 or arm64]to explicitly enable these platforms
🔗 Analysis chain
Add osx-arm64 platform support
The PR objective mentions enabling builds for both linux-aarch64 and osx-arm64, but only linux-aarch64 is configured. Consider adding osx-arm64 platform support as well.
Let's verify if the version bump is consistent with upstream:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Verify if 2.3.1 is the latest release
gh release view --repo gmarcais/Jellyfish v2.3.1 --json publishedAt,tagName,name
Length of output: 217
Script:
#!/bin/bash
# Let's try a different approach to verify the version
# 1. Check the source URL in meta.yaml
cat recipes/kmer-jellyfish/meta.yaml | grep -A2 "source:"
# 2. Check if this is the latest release using a different GitHub API endpoint
gh api repos/gmarcais/Jellyfish/releases/latest --jq '.tag_name'
# 3. Let's also verify the platform configuration
cat recipes/kmer-jellyfish/meta.yaml | grep -A5 "build:"
Length of output: 579
Script:
#!/bin/bash
# Let's check the platform configuration in meta.yaml
cat recipes/kmer-jellyfish/meta.yaml | grep -A10 "^build:" | grep -E "skip|platform"
# Also check if there are any platform-specific sections
cat recipes/kmer-jellyfish/meta.yaml | grep -E "^\s*\[(osx-arm64|linux-aarch64|aarch64)]"
Length of output: 204
…rking as intended
|
Merging this for now; couldn't build on |
|
thanks @mencian! |
Trying to build kmer-jellyfish for linux-aarch64 and osx-arm64
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add labelcommand.@bioconda/corein a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports(see here for the rationale and comprehensive explanation).Add a
run_exportssection like this:with
...being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}while replacing
"myrecipe"with eithernameif aname|lowervariable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update@BiocondaBot please add labelplease review & mergelabel.@BiocondaBot please fetch artifactsYou can use this to test packages locally.
Note that the
@BiocondaBot please mergecommand is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>and will automatically re-post them to notify the addressed<team>.