Update ms2rescore to 3.1.4 #49446
Update ms2rescore to 3.1.4 #49446
Conversation
📝 Walkthrough📝 Walkthrough📝 Walkthrough📝 Walkthrough📝 Walkthrough📝 Walkthrough📝 WalkthroughWalkthroughThe Changes
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
BiocondaBot
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
recipes/ms2rescore/meta.yaml (2)
21-22: LGTM: Build section updates look good.The new entry point for 'tims2rescore' has been added, which is consistent with the addition of a new main function. The installation script has been modified to include the '--no-cache-dir' option.
Consider adding a comment to explain why the '--no-cache-dir' option is necessary. This can help future maintainers understand the reasoning behind this change.
34-34: Dependency updates look good, but consider upper bound for pyteomics.The version constraints for pyteomics and psm-utils have been updated to require newer versions, which is good for incorporating bug fixes and new features.
Consider adding an upper bound to the pyteomics dependency to prevent potential compatibility issues with future major versions. For example:
- pyteomics >=4.7.2,<5Also applies to: 45-45
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- recipes/ms2rescore/meta.yaml (4 hunks)
🔇 Additional comments (6)
recipes/ms2rescore/meta.yaml (6)
2-2: LGTM: Version update is correct.The package version has been updated to 3.1.3.post1, which is consistent with the PR objectives and follows PEP 440 versioning standards.
55-55: LGTM: Replacement of seaborn with seaborn-base is beneficial.The change from seaborn to seaborn-base is a good optimization. seaborn-base is a lighter version that excludes sample datasets and example scripts, which aren't necessary for ms2rescore's functionality. This change can reduce the package size and installation time.
51-51: LGTM: Version constraint reordering for sqlalchemy and xgboost.The version constraints for sqlalchemy and xgboost have been reordered but remain functionally equivalent to the previous constraints. This change maintains consistency in the formatting of version constraints throughout the file.
Also applies to: 56-56
63-63: Clarification needed: Commented out test command.The test command for ms2rescore-gui has been commented out. While there may be a valid reason for this change, it could potentially lead to reduced test coverage.
Could you please clarify why this test command was commented out? Is the GUI functionality still available and tested through other means?
10-10: LGTM: Source URL and checksum updated.The source URL has been correctly updated to reflect the new version, and the SHA256 checksum has been changed accordingly.
To ensure the integrity of the package, please verify the SHA256 checksum:
43-43: New dependency im2deep added.The addition of im2deep >=0.1.3 as a new dependency is noted.
To better understand the purpose of this new dependency, please run the following command to check its description:
Could you provide more information about why this dependency was added and what functionality it provides to ms2rescore?
BiocondaBot
changed the title
|
Can be closed in favor of #53367. |
Update
ms2rescore: 3.0.3 → 3.1.4recipes/ms2rescore(click to view/edit other files)This pull request was automatically generated (see docs).