Pangolin scikit-learn fix #42145
Merged
Pangolin scikit-learn fix #42145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pangoLEARN models are not receiving updates any longer and existing models were built with the 1.2 series of scikit-learn, i.e. cannot be loaded with 1.3 and higher.
bgruening
approved these changes
Jul 24, 2023
|
Hmm, the issue is that snakemake dropped support for Python < 3.9 (https://github.com/snakemake/snakemake/blob/9cfcd917e6430cec72217a284222ed19574677f3/snakemake/__init__.py#L8-L9) in the very recent "minor" release 7.30.2 without mentioning it in the release notes. Not sure where this should be fixed, but probably not here? |
|
I assume #42147 would be the correct fix? |
|
Excluding snakemake 7.30.2 for now since updating to Python 3.9 would also require unpinning Biopython and possibly other changes, which seems like a drastic change for just a new build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.