Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace t_coffee with t-coffee #38199

Merged
merged 4 commits into from
Dec 14, 2022
Merged

Replace t_coffee with t-coffee #38199

merged 4 commits into from
Dec 14, 2022

Conversation

amizeranschi
Copy link
Contributor

@amizeranschi amizeranschi commented Dec 2, 2022

In light of the recent un-blacklisting and update of t-coffee (a78d91b), it should now replace t_coffee as a dependency here.

For more info: #32576 (comment)

@nsoranzo
Copy link
Contributor

nsoranzo commented Dec 2, 2022

Can you please fix the linting issues (bump the build number and remove the skip line)?

@0xaf1f
Copy link
Contributor

0xaf1f commented Dec 2, 2022

I think this PR should also be marked as resolving the issue #32576. I'm excited to see it land!

@amizeranschi
Copy link
Contributor Author

Can you please fix the linting issues (bump the build number and remove the skip line)?

OK, did I properly address what you meant?

@nsoranzo
Copy link
Contributor

nsoranzo commented Dec 2, 2022

@amizeranschi Yes, thanks, let's see if tests pass now!

@0xaf1f
Copy link
Contributor

0xaf1f commented Dec 7, 2022

@dpryan79, are we sure that the new t-coffee package is working now? This package is trying to switch to using it but the tests fail when trying to run t-coffee. With several errors like

15:21:37 BIOCONDA INFO (OUT) #   Failed test at t/TCoffee.t line 74.
15:21:37 BIOCONDA INFO (OUT) # died:
15:21:37 BIOCONDA INFO (OUT) # ------------- EXCEPTION -------------
15:21:37 BIOCONDA INFO (OUT) # MSG: TCoffee call crashed: 256 [command /opt/conda/conda-bld/perl-bio-tools-run-alignment-tcoffee_1669994129120/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/bin/t_coffee  -profile=wFKPu888Ma -seq=ty5F_FnXFD -matrix=blosum -method=lalign_id_pair,clustalw_pair  -ktuple=3 -outfile=/tmp/fVnlE_JMmE/Aede5VRDuk -output=clustalw -quiet]
15:21:37 BIOCONDA INFO (OUT) #

@nsoranzo
Copy link
Contributor

nsoranzo commented Dec 7, 2022

I see similar errors with the Galaxy wrapper, it seems a recent rebuild is causing issues (it was definitely working before with the same t-coffee version).

@0xaf1f
Copy link
Contributor

0xaf1f commented Dec 10, 2022

Yes, the t-coffee package build was not complete and that's what doomed this package's test. I described the bug and made a pull request to fully build t-coffee.

@0xaf1f
Copy link
Contributor

0xaf1f commented Dec 14, 2022

Can we re-run the builds now that the new t-coffee package is in the archive? I tested the failing test suite command here using the new t-coffee build and can confirm it works.

amizeranschi and others added 4 commits December 14, 2022 09:06
In light of the recent un-blacklisting and update of `t-coffee` (a78d91b), it should now replace `t_coffee` as a dependency here.

For more info: #32576 (comment)
@nsoranzo
Copy link
Contributor

@BiocondaBot please merge

@BiocondaBot
Copy link
Collaborator

I will attempt to upload artifacts and merge this PR. This may take some time, please have patience.

@BiocondaBot BiocondaBot merged commit 28d95f0 into bioconda:master Dec 14, 2022
cokelaer pushed a commit to cokelaer/bioconda-recipes that referenced this pull request Apr 28, 2023
Merge PR bioconda#38199, commits were: 
 * Remove commented out line
 * Update meta.yaml
 * Update meta.yaml
 * Replace t_coffee with t-coffee

In light of the recent un-blacklisting and update of `t-coffee` (bioconda@a78d91b), it should now replace `t_coffee` as a dependency here.

For more info: bioconda#32576 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants