fix: set AddPathLen for BGP Routes when received via grpc #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Istvan91
force-pushed
the
lpm_force_sorted_best_path
branch
from
7cf35d3 to
081a843
Compare
|
fixed the corresponding test |
|
Many thanks for troubleshooting and fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using ris-mirror the routes weren't sorted by BestPath:
The ASPathLen value was not set when decoding BGP Paths from proto and defaulted back to zero => all routes where treated as having the same ASPathLen, regardless of the actual ASPath.