BGP: Fix IPv4 listen addr configuration #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #451 +/- ##
==========================================
- Coverage 54.34% 52.79% -1.56%
==========================================
Files 146 152 +6
Lines 7901 8160 +259
==========================================
+ Hits 4294 4308 +14
- Misses 3401 3646 +245
Partials 206 206
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
taktv6
reviewed
Oct 12, 2023
BarbarossaTM
force-pushed
the
fix/ListenIPv4
branch
from
4ba4f23 to
042cb0a
Compare
This removes some duplicate code and introduces a new helper function
netTCPAddrToSockAddr(*net.TCPAddrr) unix.Sockaddr
to do the conversaion on one place, including regression tests.
Closes #450
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic>
BarbarossaTM
force-pushed
the
fix/ListenIPv4
branch
from
042cb0a to
9e214c6
Compare
taktv6
approved these changes
Oct 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #450