ignore creators with [null] values

bio-guoda · Sep 6, 2024 · 0c12912 · 0c12912
1 parent 654662f
commit 0c12912
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/preston-taxodros/src/main/java/bio/guoda/preston/cmd/DarkTaxonUtil.java b/preston-taxodros/src/main/java/bio/guoda/preston/cmd/DarkTaxonUtil.java
@@ -83,7 +83,7 @@ public static ObjectNode toPhotoDeposit(JsonNode multimediaRecord, PublicationDa
         }
 
         JsonNode creatorNode = multimediaRecord.get("http://purl.org/dc/elements/1.1/creator");
-        List<String> creators = Arrays.asList(creatorNode == null ? "Museum für Naturkunde Berlin" : creatorNode.asText());
+        List<String> creators = Arrays.asList(creatorNode == null || creatorNode.isNull() ? "Museum für Naturkunde Berlin" : creatorNode.asText());
         populatePhotoDepositMetadata(
                 zenodoMetadata,
                 filename,

diff --git a/preston-taxodros/src/test/java/bio/guoda/preston/cmd/DarkTaxonUtilTest.java b/preston-taxodros/src/test/java/bio/guoda/preston/cmd/DarkTaxonUtilTest.java
@@ -26,9 +26,7 @@ public void photoDeposit() throws IOException {
         ObjectNode zenodoDeposit = DarkTaxonUtil.toPhotoDeposit(multimedia, getPublicationDateFactory(), Arrays.asList("mfn-test"));
 
         String actual = zenodoDeposit.toPrettyString();
-
-        System.out.println(actual);
-
+
         assertThat(actual, Is.is(IOUtils.toString(getClass().getResourceAsStream("darktaxon/multimedia-zenodo.json"), StandardCharsets.UTF_8)));
 
     }

diff --git a/preston-taxodros/src/test/resources/bio/guoda/preston/cmd/darktaxon/multimedia-zenodo.json b/preston-taxodros/src/test/resources/bio/guoda/preston/cmd/darktaxon/multimedia-zenodo.json
@@ -32,7 +32,7 @@
     "upload_type" : "image",
     "image_type" : "photo",
     "creators" : [ {
-      "name" : "null"
+      "name" : "Museum für Naturkunde Berlin"
     } ],
     "publication_date" : "1999-12-31",
     "communities" : [ {