Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0.0 stable #742

Merged
merged 3 commits into from
Mar 6, 2025
Merged

2.0.0 stable #742

merged 3 commits into from
Mar 6, 2025

Conversation

VictorKoenders
Copy link
Contributor

No description provided.

@@ -1,11 +1,12 @@
[package]
name = "bincode_derive"
version = "2.0.0-rc.3" # remember to update bincode
version = "2.0.0" # remember to update bincode
authors = [
"Zoey Riordan <zoey@dos.cafe>",
"Victor Koenders <bincode@trangar.com>",
]
edition = "2021"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rust 1.85 brings support for Edition2024, maybe that could be updated as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We currently don't see the point of upgrading to 2024, as the rust compiler will still be able to run 2021 code. We do have the option to bump to 2024 later if we want to start adding new 2024 features

@lherman-cs
Copy link

@VictorKoenders 2024 edition has become stable, rust-lang/rust#133349. What can we do to help releasing bincode 2.0.0?

@VictorKoenders
Copy link
Contributor Author

Start by banning 40 hour work weeks, they're exhausting

@VictorKoenders VictorKoenders force-pushed the release/2.0.0-stable branch 2 times, most recently from 2b3fac5 to 0cf3624 Compare March 2, 2025 16:28
@VictorKoenders
Copy link
Contributor Author

Would be really nice if we can merge #710 before releasing 2.0

@ZoeyR
Copy link
Collaborator

ZoeyR commented Mar 3, 2025

The readme's MSRV section should be updated to reflect the selected MSRV. Additionally, it should have a sentence mentioning that some features (e.g. serde) will change MSRV guarantees. I suggest adding a column in the lib.rs feature table documenting if a feature is MSRV affecting or not

@ZoeyR ZoeyR marked this pull request as ready for review March 6, 2025 16:49
@ZoeyR ZoeyR merged commit a338109 into trunk Mar 6, 2025
100 of 101 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants