Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add liveman cascade pull stream feature #268

Merged
merged 7 commits into from
Jan 7, 2025
Merged

Conversation

agougougoua
Copy link
Contributor

Add pull stream feature

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 3.12500% with 62 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
liveman/src/route/utils.rs 0.00% 34 Missing ⚠️
liveman/src/route/cascade.rs 0.00% 27 Missing ⚠️
liveman/src/config.rs 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
libs/net4mqtt/src/utils.rs 100.00% <100.00%> (ø)
liveman/src/config.rs 0.00% <0.00%> (ø)
liveman/src/route/cascade.rs 0.00% <0.00%> (ø)
liveman/src/route/utils.rs 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

Copy link
Member

@a-wing a-wing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And need fix CI error

  • cargo fmt
  • cargo clippy

listen = "0.0.0.0:8888"
listen = "127.0.0.1:8888"
[cascade]
mode = "pull"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This config items move to conf/liveman.toml and add some comment

@a-wing a-wing added enhancement New feature or request mod::liveman Cloud Manager labels Jan 7, 2025
@a-wing a-wing added this to the 0.8.0 milestone Jan 7, 2025
@@ -39,6 +39,10 @@
# maximum_idle_time = 60000
# When cascade is working, close src server not cascade push session subscription
# close_other_sub = false
# Cascade operating mode
# Options: "push" or "pull". Determines whether cascade operates in push mode or pull mode.
# Default is "pull"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default is 'push', right?

@a-wing a-wing changed the title Add pull stream feature Add liveman cascade pull stream feature Jan 7, 2025
@a-wing a-wing merged commit 0a5db98 into binbat:main Jan 7, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request mod::liveman Cloud Manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants