-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add liveman cascade pull stream feature #268
Conversation
Codecov ReportAttention: Patch coverage is
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And need fix CI error
-
cargo fmt
-
cargo clippy
conf/livenil/liveman.toml
Outdated
listen = "0.0.0.0:8888" | ||
listen = "127.0.0.1:8888" | ||
[cascade] | ||
mode = "pull" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This config items move to conf/liveman.toml
and add some comment
conf/liveman.toml
Outdated
@@ -39,6 +39,10 @@ | |||
# maximum_idle_time = 60000 | |||
# When cascade is working, close src server not cascade push session subscription | |||
# close_other_sub = false | |||
# Cascade operating mode | |||
# Options: "push" or "pull". Determines whether cascade operates in push mode or pull mode. | |||
# Default is "pull" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Default is 'push', right?
Add pull stream feature