fix(space-card): make favorite btn available to non admin users (#426)

bimdata · Oct 27, 2023 · 9d8f1fa · 9d8f1fa
1 parent 694cb7a
commit 9d8f1fa
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 8 deletions.
diff --git a/src/components/specific/app/app-header/AppHeader.scss b/src/components/specific/app/app-header/AppHeader.scss
@@ -21,6 +21,7 @@
   }
 
   &__invit-btn {
+    position: relative;
     margin: 0 var(--spacing-unit);
 
     &__notif {

diff --git a/src/components/specific/spaces/space-card/SpaceCard.vue b/src/components/specific/spaces/space-card/SpaceCard.vue
@@ -6,10 +6,7 @@
   >
     <BIMDataCard class="space-card">
       <template #right>
-        <SpaceCardActionMenu
-          v-if="actionMenu && space.isAdmin"
-          :space="space"
-        />
+        <SpaceCardActionMenu v-if="actionMenu" :space="space" />
       </template>
       <template #content>
         <div v-if="space.isFree" class="free-badge">

diff --git a/src/components/specific/spaces/space-card/space-card-action-menu/SpaceCardActionMenu.scss b/src/components/specific/spaces/space-card/space-card-action-menu/SpaceCardActionMenu.scss
@@ -8,12 +8,9 @@
   }
 
   &__container {
-    $card-menu-height: 132px;
-
     position: absolute;
     right: 0;
     width: calc(#{$card-width} - var(--spacing-unit));
-    min-height: $card-menu-height;
     margin-top: calc(var(--spacing-unit) / 2);
     padding: calc(var(--spacing-unit) / 2) 0;
     border-radius: 4px;

diff --git a/src/components/specific/spaces/space-card/space-card-action-menu/SpaceCardActionMenu.vue b/src/components/specific/spaces/space-card/space-card-action-menu/SpaceCardActionMenu.vue
@@ -48,6 +48,7 @@
                 }}
               </BIMDataButton>
               <BIMDataButton
+                v-if="space.isAdmin"
                 data-test-id="btn-open-update"
                 ghost
                 squared
@@ -56,12 +57,13 @@
                 {{ $t("t.rename") }}
               </BIMDataButton>
               <SpaceCardImageButton
+                v-if="space.isAdmin"
                 data-test-id="btn-update-image"
                 :space="space"
                 @upload-completed="closeMenu"
               />
               <BIMDataButton
-                v-if="space.image"
+                v-if="space.isAdmin && space.image"
                 data-test-id="btn-delete-image"
                 ghost
                 squared
@@ -70,6 +72,7 @@
                 {{ $t("SpaceCardActionMenu.removeImageButtonText") }}
               </BIMDataButton>
               <BIMDataButton
+                v-if="space.isAdmin"
                 data-test-id="btn-open-delete"
                 color="high"
                 ghost