Skip to content

Commit

Permalink
Make namespace declarations consistent (CrayLabs#434)
Browse files Browse the repository at this point in the history
Make py/SmartRedis namespace declarations consistent throughout the pybind layer
[ committed by @billschereriii ]
[ reviewed by @mellis13 ]
  • Loading branch information
billschereriii authored Dec 6, 2023
1 parent 9fb1507 commit 8ba2c40
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
3 changes: 3 additions & 0 deletions doc/changelog.rst
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ To be released at some future point in time

Description

- Improved consistency of namespace declarations for C++ pybind interface
- Improved const correctness of C++ Client
- Improved const correctness of C++ Dataset
- Updated documentation
Expand All @@ -32,6 +33,7 @@ Description

Detailed Notes

- Made the declaration of the py namespace in py*.h consistently outside the SmartRedis namespace declaration (PR434_)
- Fields in several C++ API methods are now properly marked as const (PR430_)
- The Dataset add_tensor method is now const correct, as are all internal the methods it calls (PR427_)
- Some broken links in the documentation were fixed, and the instructions to run the tests were updated (PR423_)
Expand All @@ -53,6 +55,7 @@ Detailed Notes
- Create CONTRIBUTIONS.md file that points to the contribution guideline for both SmartSim and SmartRedis (PR395_)
- Migrated to ConfigOptions-based Client construction, adding multiple database support (PR353_)

.. _PR434: https://github.com/CrayLabs/SmartRedis/pull/434
.. _PR430: https://github.com/CrayLabs/SmartRedis/pull/430
.. _PR427: https://github.com/CrayLabs/SmartRedis/pull/427
.. _PR423: https://github.com/CrayLabs/SmartRedis/pull/423
Expand Down
4 changes: 2 additions & 2 deletions include/pyclient.h
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,10 @@

///@file

namespace SmartRedis {

namespace py = pybind11;

namespace SmartRedis {

/*!
* \brief The PyClient class is a wrapper around the
C++ client that is needed for the Python
Expand Down
1 change: 0 additions & 1 deletion include/pyconfigoptions.h
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@

namespace py = pybind11;


namespace SmartRedis {


Expand Down

0 comments on commit 8ba2c40

Please sign in to comment.