Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing mappings and a patch function #40

Merged
merged 4 commits into from
Jun 1, 2021

Conversation

fkunz
Copy link
Contributor

@fkunz fkunz commented May 8, 2021

Nothing new, just filling the gaps.

Added Payment Model to access payments in order data.

Added patchAddress implementation following pathProduct.

Added id mapping in Address Model, needed for patch call.

Florian Kunz added 3 commits May 8, 2021 17:59
Added function patchAddress to be able to modify malformed or wrong shipping address
Added Payment Model and mapping in Order Model to be able to extract payments for accounting.
Copy link
Member

@devtronic devtronic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing. I reviewed your changes and left two comments.

src/Model/Payment.php Outdated Show resolved Hide resolved
src/Model/Payment.php Outdated Show resolved Hide resolved
Co-authored-by: Julian Finkler <julian@developer-heaven.de>
@fkunz fkunz requested a review from devtronic May 16, 2021 09:01
@devtronic devtronic merged commit 84cb954 into billbeeio:master Jun 1, 2021
@devtronic
Copy link
Member

@fkunz: The changes are included in v1.9.0.

devtronic added a commit that referenced this pull request Oct 28, 2021
* Update usage_without_composer.md

* URL encode path parameters

* Added missing mappings and a patch function (#40)

Added:
- `Client::patchAddress()`
- Mapping for `Address::$id`
- Mapping for `Order::$payments`
- `Payment` model

* Update CHANGELOG.md

Co-authored-by: fkunz <fkunz@users.noreply.github.com>
devtronic added a commit that referenced this pull request Oct 28, 2021
* Refactored the structure and rewrote the unit tests (#35)

* Added phpstan for static code analysis (#36)

Added phpstan for static code analysis

* Updated the min. PHP Version to 7.3 and updated updated the PHPUnit package (#37)

* Copyright updated and php constraints updated

* Changelog updated

* Changed the required PHP CPU architecture to 64bit

* Updated the CHANGELOG.md

* Updated Guzzle to v7.4.0 and psr/log to v1.1.0 (#48)

* Updated Guzzle to v7.4.0 and psr/log to v1.1.0

* Renamed BillbeeClient to CustomClient

* Updated the API endpoint and added the Changelog entry

* Merge master in 2.0.0 (#50)

* Update usage_without_composer.md

* URL encode path parameters

* Added missing mappings and a patch function (#40)

Added:
- `Client::patchAddress()`
- Mapping for `Address::$id`
- Mapping for `Order::$payments`
- `Payment` model

* Update CHANGELOG.md

Co-authored-by: fkunz <fkunz@users.noreply.github.com>

* Merge remote-tracking branch 'origin/master' into 2.0.0

# Conflicts:
#	CHANGELOG.md
#	src/Client.php

Co-authored-by: fkunz <fkunz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants