Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unpacks only once #86

Merged
merged 4 commits into from
Aug 18, 2015
Merged

unpacks only once #86

merged 4 commits into from
Aug 18, 2015

Conversation

andia89
Copy link
Collaborator

@andia89 andia89 commented Aug 18, 2015

Ok, it works now. Had a few problems because you switched from relative to absolute paths for the chrome script.

Btw. Can you enlighten me, what the counter (i) in the get_apps_informations functions is for? Seems to be useless for me

@bilelmoussaoui
Copy link
Owner

well it was just to not read the first line, i had no idea how to do that :P as the first line in db.csv is just a description

@andia89
Copy link
Collaborator Author

andia89 commented Aug 18, 2015

I see, but then a r.next() (to skip the line) would be better I guess, instead of this if``else clause. Plus your if else basically does nothing because pass doesn't do anything. I'll add this to my PR :)

@bilelmoussaoui
Copy link
Owner

i will do that this evening

Le 18 août 2015 à 09:31, Andreas Angerer notifications@github.com a écrit :

I see, but then a r.next() (to skip the line) would be better I guess, instead of this ifelse clause. Plus your if else basically does nothing because pass doesn't do anything


Reply to this email directly or view it on GitHub.

@bilelmoussaoui
Copy link
Owner

Thanks!! You've removed a comment from data_pack is that fine?

@andia89
Copy link
Collaborator Author

andia89 commented Aug 18, 2015

Yes, because we are not doing what is written there

bilelmoussaoui added a commit that referenced this pull request Aug 18, 2015
@bilelmoussaoui bilelmoussaoui merged commit 567f040 into bilelmoussaoui:master Aug 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants