Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update script.py #83

Merged
merged 3 commits into from
Aug 16, 2015
Merged

Update script.py #83

merged 3 commits into from
Aug 16, 2015

Conversation

andia89
Copy link
Collaborator

@andia89 andia89 commented Aug 16, 2015

I think the comments were mostly ok :)
My programming teacher always said: Good code doesn't need comments :P

I think the comments were mostly ok :)
My programming teacher always said: Good code doesn't need comments :P
@bilelmoussaoui
Copy link
Owner

As we both are the only ones who modify the script, the comments are unneeded :p as you've changed the comment from real to correct in get_real_chrome.. can you change the function name too? 👍

@bilelmoussaoui
Copy link
Owner

Thanks!

bilelmoussaoui added a commit that referenced this pull request Aug 16, 2015
@bilelmoussaoui bilelmoussaoui merged commit 7edc230 into bilelmoussaoui:master Aug 16, 2015
@andia89 andia89 deleted the patch-3 branch August 16, 2015 13:32
@Foggalong
Copy link
Contributor

Comments are always useful to have. If someone else comes along down the line and wants to contribute it makes it easier for them to understand what's going on, as well as being a quick review for yourselves for what each component does.

@bilelmoussaoui
Copy link
Owner

👍 That's why, i asked for someone to correct/update them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants