Update database file for wire-desktop (Electron) #574
Conversation
(https://github.com/wireapp/wire-desktop/wiki/How-to-install-Wire-for-Desktop-on-Linux) Signed-off-by: Peter J. Mello <admin@petermello.net>
Signed-off-by: Peter J. Mello <admin@petermello.net>
Signed-off-by: Peter J. Mello <admin@petermello.net>
|
Thanks for the MR. we already have a license here https://github.com/bilelmoussaoui/Hardcode-Tray/tree/master/license can you remove that from your PR? |
|
Sure thing, LICENSE file is now gone. I added it primarily to interact with a Mediawiki extension I use to help me update Wikipedia pages for FOSS projects. What are your thoughts on symlinking the GPL file in the directory you linked to above to LICENSE in the repo's root dir? Just curious. |
|
Yeah that would be great. As currently, github doesn't detect the right license. Maybe linking it to the README file in the license directory so the user can get an idea of why we do use a double license |
|
Any chance we could get that link so I can merge this? Thanks for this and also for the changes you have done to the wiki! |
Signed-off-by: Peter J. Mello <admin@petermello.net>
|
Sorry for the lack of progress on this PR. I actually fell down the rabbit hole of FOSS licensing for a few days, attempting to better understand what standards are in place and what the best practices might be, finally ending up trying to make some kind of sense out of the SPDX Specification. That's what led me to name the symlinks the way I did, as that seems to be the way they want to handle projects with any sort of conjunctive licensing. There's still more to do in order to bring the repository into full compliance with their idea of how things should be done (like adding a one-liner tag somewhere in the project README and a little bit of formatting to alter in the license folder README), but don't feel like you need to wait for any of it before merging if that's what you want to do. I'll continue to tinker with things in my fork simply because I'd like to gain some facility with properly promulgating licenses within more complex projects, and if you're interested in where it leads then we can take another twirl out on the dancefloor. 😜 |
|
Perfect! Thanks for the update! Will review and merge any other PR you send later. |
Upon seeing that Hardcode-Tray wasn't handling the icon for the wire-desktop app, I saw that the database file needed to be updated consistent with the paths and filenames used by the current installer available from their official Debian repository. This is my attempt to do just that.
Output of "apt show wire-desktop"
Output of "dpkg -L wire-desktop" (sans contents of node_modules folder per Github PR char. limit)
After making the changes to my local
/usr/share/hardcode-tray/database/wire.electron.jsonconsistent with commit 9431d59 I ran Hardcode-Tray again and it successfully recognized and converted its tray icons. I also rebuilt from source, using my fork with the committed changes present, and encountered no errors.Finally, I noticed that the CircleCI badge was a broken link as parsed from the README.md file, concluded that the cause was an errant hyphen in the username portion of the Github repo URL, and corrected such. Observed result is that the badge renders as expected.