Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the last commit it dawned on me that the script is detecting what desktop enviroment the user is using, even though it only really needs to check for XFCE or Pantheon. I gutted all of superfluous stuff and shortened the function name to make it generally a bit lighter.
Various changes to make the script follow the PEP8 Styleguide. These include:
# COMMENT
item1, item2, item3
)The one thing from PEP8 I haven't fixed is the line limit of 79 characters because it would require a bit more work in restructuring the functions.
Together these changes mean the line count is slightly more, but the file size is slightly less. I think that's it from me for changes for now :)