Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimisations and PEP8 compliance #37

Merged
merged 1 commit into from
Jun 29, 2015
Merged

Optimisations and PEP8 compliance #37

merged 1 commit into from
Jun 29, 2015

Conversation

Foggalong
Copy link
Contributor

  • After the last commit it dawned on me that the script is detecting what desktop enviroment the user is using, even though it only really needs to check for XFCE or Pantheon. I gutted all of superfluous stuff and shortened the function name to make it generally a bit lighter.

  • Various changes to make the script follow the PEP8 Styleguide. These include:

    • Removed trailing spaces
    • Comments formatted # COMMENT
    • Inline comments separated by 2 spaces
    • 2 newlines between each definition
    • Spaces around operators
    • Spaces in comma lists (item1, item2, item3)

    The one thing from PEP8 I haven't fixed is the line limit of 79 characters because it would require a bit more work in restructuring the functions.

Together these changes mean the line count is slightly more, but the file size is slightly less. I think that's it from me for changes for now :)

bilelmoussaoui added a commit that referenced this pull request Jun 29, 2015
Optimisations and PEP8 compliance
@bilelmoussaoui bilelmoussaoui merged commit 7f3f8df into bilelmoussaoui:master Jun 29, 2015
@bilelmoussaoui
Copy link
Owner

Thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants