Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Telegram path #336

Merged
merged 1 commit into from
Mar 28, 2017

Conversation

vayan
Copy link
Contributor

@vayan vayan commented Mar 27, 2017

@bilelmoussaoui
Copy link
Owner

The app path shouldn't point to a folder, as it might be empty... the best way to fix this is to look for the Telegram binary file (maybe under /usr/bin?) or /opt/Telegram?

@vayan
Copy link
Contributor Author

vayan commented Mar 28, 2017

With the official install there's no install script or anything (from https://desktop.telegram.org/) you can extract the binaries anywhere. But maybe we can look for a specific file under ~/.local/share/TelegramDesktop/ ?

@bilelmoussaoui
Copy link
Owner

Alright, can you do that please ? I'm using my phone for few days.. this way I can merge your PR as soon as possible

With the official tarball we can extract the binaries anywhere, so we need to
rely on something else than the binaries path to detect a Telegram install.

Fix bilelmoussaoui#335
@vayan vayan force-pushed the add-new-telegram-path branch from e3c7d55 to 95561d5 Compare March 28, 2017 20:53
@vayan
Copy link
Contributor Author

vayan commented Mar 28, 2017

Done! I used the log file, created on every start of the app.

@bilelmoussaoui bilelmoussaoui merged commit c9a4280 into bilelmoussaoui:master Mar 28, 2017
@bilelmoussaoui
Copy link
Owner

Perfect! thanks, i will create a new release pretty soon 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants