Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ElectronMail support #577

Closed
ghost opened this issue Apr 1, 2019 · 7 comments
Closed

Add ElectronMail support #577

ghost opened this issue Apr 1, 2019 · 7 comments

Comments

@ghost
Copy link

ghost commented Apr 1, 2019

Add please app ElectronMail.
https://github.com/vladimiry/ElectronMail

@varlesh
Copy link
Collaborator

varlesh commented Apr 2, 2019

@Faust30000 How this worked? You can show screenshot with notification mail status?
on source code numbers draw as font:

const icon = appRelativePath("./assets/icons/icon.png");
    return Object.assign({ appDir,
        userDataDir,
        icon, trayIcon: icon, numbersFont: appRelativePath("./assets/numbers.ttf"), browserWindowPage: developmentEnv

@varlesh
Copy link
Collaborator

varlesh commented Apr 2, 2019

app used packed asar:

  • icons path: /opt/ElectronMail/resources/
  • icon: app/assets/icons/icon.png

@varlesh
Copy link
Collaborator

varlesh commented Apr 2, 2019

@Faust30000 It's badge used for tray?
image

varlesh added a commit to PapirusDevelopmentTeam/papirus-icon-theme that referenced this issue Apr 2, 2019
@varlesh
Copy link
Collaborator

varlesh commented Apr 2, 2019

Papirus icon added:
PapirusDevelopmentTeam/papirus-icon-theme@f83c1c8
PR for hardcode-tray database:
e6e449b

@bilelmoussaoui
Copy link
Owner

Fixed! Thank you @varlesh

@varlesh
Copy link
Collaborator

varlesh commented Apr 2, 2019

@Faust30000
image
But i'm not check notification icon, because not have Proton account

@vladimiry
Copy link

vladimiry commented Nov 20, 2021

You should not override the ElectronMail tray icon by a static one. It's actually gets rendered dynamically/programmatically. See vladimiry/ElectronMail#464 (comment). So if you need to make it look black/white style you can make it via the app's settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants