Support more apps

[bilelmoussaoui]

Wel, still needs to support more apps :

• Viber -wontfix-
• Spotify
• Google chrome
• Telegram
• Google Music Manager

Sni-qt apps? I'm not sure that i will implement anything like this in my code..But who knows

• Megasync
• Skype
• OwnCloud -not hardcoded-

[bilelmoussaoui]

For Viber ,the icon used as an indicator is 16x16.png which is not very specific as an icon name. I really don't have any ideas about this?

[andia89]

This could be circumvented by using an additional column in your csv. One column for the name of the icon in the icon theme, one for the icon name that is hardcoded and the symlink (or converted png) is pointing to. And this column could be just an empty string if theres no difference betwen the two names (like for the ones you support already) and not empty otherwise

[bilelmoussaoui]

I thought about this too, but if i do so the designers must choose the same name of the viber indicator?
For the Spotify and google chrome icons. We have to open a zip file, change the icon file and compress it again, So maybe i will create a bash script for this.

[andia89]

No. I don't think so. You just name it viber-indicator.svg or whatever the designer want to call it. Afterwards you can symlink it to 24x24.png (or convert it to this filename).
Yeah google is not really doable I think, spotify probably is

[bilelmoussaoui]

I will try this. I think about writing a code that will look if there's any icon that uses viber in it's name and use it? That will make the designers free to use whatever they want as an icon name? And i will implement this asap

[bilelmoussaoui]

Just to have your point of view. For spotify the app uses some icons in a zip file. The fastest way is to write a bash script code to do this and call it in the python script?

[andia89]

Much late replay:/ yes Most definitely the fastest Way python is really bad in handling zip files

[bilelmoussaoui]

It's not a problem! i will support the rest of applications after my finals

[andia89]

Owncloud is Not hardcoded

[bilelmoussaoui]

Owncloud is qt application to change the icons you've to install a patched version of sni-qt and copy the icons to /tmp
the same case is for megasync and skype

[andia89]

I'm using owncloud right now, and the icons from numix are used

[bilelmoussaoui]

Well, if you say so :D the last time i used owncloud, i had such ugly icons

[bilelmoussaoui]

Do you have any idea how to open a .pak archive file? if it's possible of course

[andia89]

There seems to be a python script that can work with .pak files. You could add that to the script folder...
https://code.google.com/p/grit-i18n/source/browse/trunk/grit/format/data_pack.py

[bilelmoussaoui]

@wa4557 can you take a look at this ? ElementaryPlus Owncloud Icon issue and confirm that's working for you?

[andia89]

I'm using version owncloud 1.7 the icons change correct. For me these icons are NOT hardcoded

[bilelmoussaoui]

Well, i tried the 1.8.1 version in Ubuntu 14.04.2 and this is how its looks like

[andia89]

Ubuntu 15.04 with owncloud 1.7

[Foggalong]

ownCloud is hardcoded for me, Xubuntu 15.04 client 1.7 :/

[andia89]

oO
I have my package from there (although OBS seems to be down at the moment): https://software.opensuse.org/download/package?project=isv:ownCloud:desktop&package=owncloud-client

[Foggalong]

Yup, mine from the same location :(

[bilelmoussaoui]

To fix ownCloud (and the rest of icons in this list too) we will need to install a patched version of sni-qt

[bilelmoussaoui]

@wa4557 @Foggalong Can you give me the path of ownCloud? i'm going to add sni-qt apps soon

[Foggalong]

Here are all the ownCloud data locations I could find:

• /usr/share/owncloud/
• /usr/bin/owncloud
• ~/.local/share/data/ownCloud/

[andia89]

same here

[bilelmoussaoui]

@Foggalong @wa4557 I added a support to sni-qt applications, i still need a bash script to convert svg icons to png icons like the one used for spotify. The icons must be copied into ~/.local/share/sni-qt/icons/

[andia89]

I can do this on the weekend if you wish?

[Foggalong]

I don't have that folder on my machine :/

[bilelmoussaoui]

You have to installed the patched version of sni-qt and restart your machine first

Le 2 juil. 2015 à 15:58, Joshua Fogg notifications@github.com a écrit :

I don't have that folder on my machine :/

—
Reply to this email directly or view it on GitHub.

[andia89]

And where do I get this patched version?

[bilelmoussaoui]

I added a ppa in the readme, im not sure that's the latest version. If its not the case i will create a new ppa for that

Le 2 juil. 2015 à 16:22, wa4557 notifications@github.com a écrit :

And where do I get this patched version?

—
Reply to this email directly or view it on GitHub.

[andia89]

and what if I'm not on a debian based distro (fedora?)

[bilelmoussaoui]

You can download it from here i guess : Package Sni-qt

[Foggalong]

I still don't have that folder after installing the package

[bilelmoussaoui]

@Foggalong can you try installing this version elementaryPlus sni-qt. The one in the ppa is outdated

[bilelmoussaoui]

@wa4557 yeah, you can do that if you want to 👍

[andia89]

@bil-elmoussaoui What has the script to do exactly?

[bilelmoussaoui]

The script will convert the svg icons sent as a parameter to the script, and save them in .local/share/sni-qt/icons/ as a png icons with a new name that is sent as a parameter too

[andia89]

Give me a sec.

[andia89]

@bil-elmoussaoui If the source icon is a png (like in the moka icon theme) is then symlinking enough or should the file be copied?

[bilelmoussaoui]

@wa4557 a symlink will be fine

[bilelmoussaoui]

I will close and open a seperate issue for each application