No Fixing Occuring

[Foggalong]

Just done a clean install and now the script isn't working for me.

I don't know if it's relevant but the icon theme isn't being correctly detected either. I have ownCloud installed which is covered and should have been fixed, but there's also Rambox (an electron app) which isn't being fixed. I can open a new issue for that if you'd prefer?

[bilelmoussaoui]

You can always force the script to use an other icon theme than the one detected automatically! Just add --theme Numix (take a look at the readme for more info).
Can you open a new issue for Rambox? I will push a fix for it by this evening

[bilelmoussaoui]

I just add Rambox support! You can either use the git version or wait few days until i release the 4.0 version :)

[Foggalong]

Awesome, I'll get some icons for Numix asap :)

[Foggalong]

@bil-elmoussaoui ownCloud isn't still being detected / fixed 😕

[bilelmoussaoui]

Can you check if this folder exists in your case ? https://github.com/bil-elmoussaoui/Hardcode-Tray/blob/master/db.csv#L36 if not can you check if there's a folder/file that i can use to check if owncloud installed

[Foggalong]

I have /usr/share/owncloud-client/ 👍

[bilelmoussaoui]

Pushed a new commit to fix that! can you try the latest git version?

[Foggalong]

Nope, still not fixing for me 😕

[bilelmoussaoui]

@Foggalong add this to db.csv OwnCloud, owncloud, /usr/share/owncloud-client/, don't understand why it wasnt commited before..

[Foggalong]

@bil-elmoussaoui I'm having this issue again. I have both Rambox and ownCloud installed but neither are being fixed/reverted.

[bilelmoussaoui]

Are you sure that u re using the latest git version of Hardcode-Tray? If you do how do you run the script ?

Le 10 oct. 2016 à 17:52, Joshua H. Fogg notifications@github.com a écrit :

@bil-elmoussaoui I'm having this issue again. I have both Rambox and ownCloud installed but neither are being fixed/reverted.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[Foggalong]

Yup, I recloned just to be sure it wasn't a problem with my local repo. I run it using this command: sudo -E ./script.py --theme Numix

[bilelmoussaoui]

I will release a new version tonight!

[bilelmoussaoui]

I updated Hardcode-Tray to 3.2, can you try if everything works great again?

[Foggalong]

@bil-elmoussaoui Nope still not working. Can you reopen this issue?

[bilelmoussaoui]

I've added an other OwnCloud path to the database file, can you clone the repo and try again?

[Foggalong]

It now says it's being fixed, but doesn't actually fix. Also Rambox it doesn't say it's fixing either, but not sure if that's expected?

[bilelmoussaoui]

@Foggalong Do you have the patched version of sni-qt installed? and for Rambox, do you have the latest version of Numix base with Rambox icons? Also it's might due to the installation path of Rambox. On Arch, it's installed on /opt/rambox/. Can you confirm it's installed there in your case too?

• I've updated the db.csv file, can you clone and try again?

[Foggalong]

For ownCloud, the problem was that I don't have the patched sni-qt installed. The PPA doesn't have Yakkety builds though so I also can't :/

For Rambox, the installation location for Ubuntu is /opt/Rambox

[bilelmoussaoui]

Should be fixed for Rambox, just update db.csv file with the latest git version.
You can build it from source, it shouldn't be that complicated, just follow the documentation https://github.com/bil-elmoussaoui/Hardcode-Tray/wiki/How-to-build-sni-qt

[Foggalong]

@bil-elmoussaoui I'm more than happy to build from source, but it's not an especially user friendly method. Even as building from source goes it's more complicated than normal.

[bilelmoussaoui]

Alright! Hope the PPA will be updated soon, otherwise i will have to create a new PPA myself.. Does Rambox issue still occuring?

[Foggalong]

Yeah, Rambox is now working for me which is brilliant 👍 Will update you on ownCloud once I've finished building

[Foggalong]

Interesting thing for Rambox: it also changes the Rambox icon within the app to the tray icon. Guessing that there's nothing that can be done about this so no worries 👍

ownCloud though unfortunately still not fixed, even with the patched version of SNI Qt installed (inc. 32 bit version).

[bilelmoussaoui]

You can report that to Rambox dev so they can change the icon they're using there :) I only change the Tray icon..
I can't do anything about it, the issue is related to sni-qt or the way you build it! Hope that elementaryPlus guys will update their PPA soon!
This can be closed now? :)

[Foggalong]

I mean, this issue isn't really fixed. I built sni-qt using the instructions here so at the very least a disclaimer needs to be added saying that it won't work in the latest version of Ubuntu 😿

Even disregarding that, there's the problem that the script is telling the user than stuff is being fixed when it isn't. I'm not sure whether that's something that can be detected though?

[bilelmoussaoui]

I don't think there's a way to detect if the patched version of sni-qt is installed using Python, the script is telling to the user the sni-qt application were fixed which means that the icons were copied correctly to the right directory. And as mentioned on the README the user must have the patched version of sni-qt installed. And i wasn't able to build sni-qt correctly neither so :(

[Foggalong]

That's fair enough. Probably go with the disclaimer then that it doesn't work with Yakkety yet. I've filed an issue upsteam so hopefully it will be updated soon.

[bilelmoussaoui]

I'm going to close this, as i don't think that i will be able to maintain a PPA at this moment! if i find any better way to compile the patched version, i will do it!