Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing parent directories owner #172

Closed
edgard opened this issue Aug 13, 2016 · 11 comments
Closed

Changing parent directories owner #172

edgard opened this issue Aug 13, 2016 · 11 comments
Labels

Comments

@edgard
Copy link
Contributor

edgard commented Aug 13, 2016

Seems like the current version is changing the parent directories (/, /home) owner to the current user applying the fix. Check this out: https://asciinema.org/a/82689

EDIT: Ubuntu GNOME Xenial

@bilelmoussaoui
Copy link
Owner

I will take a lot asap! Thanks for reporting the issue

Le 13 août 2016 15:51, "Edgard Castro" notifications@github.com a écrit :

Seems like the current version is changing the parent directories (/,
/home) owner to the current user applying the fix. Check this out:
https://asciinema.org/a/82689


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#172, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AHTlxfv8izFtCKOW-lZ38do_QNJD0nmZks5qfcvggaJpZM4JjrlF
.

@bilelmoussaoui bilelmoussaoui modified the milestone: v4.0 Aug 14, 2016
@ghost
Copy link

ghost commented Aug 18, 2016

I had login issues on my ubuntu installation after using this (there were some permission issues I could not figure out how to fix), could this have been a reason? I did not made any attempt since I reinstalled with this just to be safe.

@bilelmoussaoui
Copy link
Owner

@edgard I've added a ignore list to avoid that. The fix was pushed to master. You can't not upgrade to the latest version (4.0) as it's still on beta! Please clone the repo, revert the permission issues caused by the script before, try again and report back if you have any issues!

@bilelmoussaoui
Copy link
Owner

@szekeres2016 Your issue has nothing to do with this as far as i can tell. The script only changes the permissions of /home in order to be able to create .sni-qt folder and change it permission to the current user applying the fix so the icons can be used by Qt apps...

@edgard
Copy link
Contributor Author

edgard commented Aug 19, 2016

Hey Bilal!

Just tried and it doesn't seem to work. There's also a small error on the script. Here's a test:
https://asciinema.org/a/19ftlqijauui811dowta5lwwb

Thanks a lot for the great work!

@ghost
Copy link

ghost commented Aug 19, 2016

Even after a reboot there seems to be no difference...

tray

EDIT: You are right... I totally missed that step, was doing the process from memory, other than TeamViewer other icons seems to be fine. Thank you!

@bilelmoussaoui
Copy link
Owner

@edgard I don't see any error message? i will push an other fix soon!
@szekeres2016 Which indicators does not work and should work or (marked as fixed when you use the script?). Have you installed the patched version of sni-qt?

bilelmoussaoui added a commit that referenced this issue Aug 19, 2016
@edgard
Copy link
Contributor Author

edgard commented Aug 19, 2016

https://github.com/bil-elmoussaoui/Hardcode-Tray/blob/master/script.py#L154

Should be "not in" instead of "is not in"? Here it's throwing an error.

@bilelmoussaoui
Copy link
Owner

Indeed! Thanks, i don't have my laptop and just trying to fix those issues using github without even testing the code :P

@edgard
Copy link
Contributor Author

edgard commented Aug 19, 2016

Last fixes working like a charm, all good in the hood!

Thanks!

@bilelmoussaoui
Copy link
Owner

Thanks for reporting! 👍
@szekeres2016 Please open a new issue if you have any unreleated issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants