Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caprine and Anatine support #169

Closed
bilelmoussaoui opened this issue Jul 17, 2016 · 3 comments
Closed

Caprine and Anatine support #169

bilelmoussaoui opened this issue Jul 17, 2016 · 3 comments

Comments

@bilelmoussaoui
Copy link
Owner

bilelmoussaoui commented Jul 17, 2016

More electron apps out there
Caprine is yet an other Facebook Messenger application built using Electron, the app.asar file is installed on /usr/share/caprine/resources/
The tray icons are
selection_002
They're stored in files/media/files/
The icon names are :

  • IconTray.png
  • IconTray@2x.png
  • IconTray@4x.png
  • IconTrayUnread.png
  • IconTrayUnread@2x.png
  • IconTrayUnread@4x.png

I don't know how we should handle this case? I thought of using the same icon for all the sizes. But what if the user switch from a normal screen to a 4K one? or a FHD one?

Anatine is a Twitter Client, built using Electron too. The application does not have a app.asar file. The content of it is extracted into /usr/share/anatine/resources/app
The tray icons are in media folder (/usr/share/anatine/resources/app/media
selection_003

The icon names are:

  • IconTray.png
  • IconTray@2x.png
  • IconTrayUnread.png
  • IconTrayUnread@2x.png

Again this is the same case as Caprine, how we should handle hidpi cases? how we can implement something like this ?

@wa4557 What do you think about this?

@andia89
Copy link
Collaborator

andia89 commented Jul 17, 2016

why not double th sizes if the filename contains @2x?

@bilelmoussaoui
Copy link
Owner Author

I will see what can i do :) shouldn't be that hard to implement!

bilelmoussaoui added a commit that referenced this issue Jul 18, 2016
@bilelmoussaoui
Copy link
Owner Author

@wa4557 Fixed the issue! Everything is working perfectly right now:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants