Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfixes #78

Merged
merged 18 commits into from
Apr 29, 2020
Merged

Hotfixes #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
0e75caf
make sure listeners are removed when component is unmounted
brainkim Apr 28, 2020
2a36504
fix sync fn component nodes being set to async generator
brainkim Apr 28, 2020
4c9ed42
prevent cascades from blowing the stack/iterating over a generator wh…
brainkim Apr 28, 2020
3ebf046
add simple example for quick testing and reproductions
brainkim Apr 28, 2020
e8efb3e
browserlists is a terrible idea and I hate every single fucking bundler
brainkim Apr 28, 2020
38e3ada
fix Copy symbol not using symbol.for
brainkim Apr 28, 2020
64af1a4
split copy tests into their own file
brainkim Apr 28, 2020
9ef2f74
add some checks that we are not passing Copy to intrinsic functions
brainkim Apr 28, 2020
ed8fe40
fix examples/simple
brainkim Apr 28, 2020
dc6f851
refactor code which was using vestigial host terminology
brainkim Apr 28, 2020
3a2f262
search for unkeyed nodes when a keyed element is matched with an keye…
brainkim Apr 28, 2020
8d3209b
standardize context iteration error messages
brainkim Apr 28, 2020
5e9109f
stop deadlocks when errors are thrown upwards
brainkim Apr 29, 2020
4752430
uniformly move iterator methods to bottom of class
brainkim Apr 29, 2020
1144f5b
update CHANGELOG.md
brainkim Apr 29, 2020
052110d
get eslint to shut up about the tests I skipped
brainkim Apr 29, 2020
079f75f
move src/index.js to src/index.jsx in simple example
brainkim Apr 29, 2020
49fed47
catch some unhandled promise rejections
brainkim Apr 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,18 @@
# Changelog
## [0.1.2] - 2020-04-29
### Fixed
- Fixed Copy element tag not using Symbol.for #69
- Fixed event listeners not being properly removed when component is unmounted #70
- Prevented child components from causing parent components to rerender while it is already rerendering #70
- Fixed keyed element logic when an unkeyed element is placed before multiple keyed elements previously rendered
- Fixed a deadlock when errors are thrown back into async generator components: #77

## [0.1.1] - 2020-04-25
### Fixed
- Correct boolean props not working correctly in html renderer #44
- Corrected boolean props not working correctly in html renderer #44
- Guarded against potential xss in style objects #44
- Wrapped non-string iterables in an implicit Fragment element #63
- Unmount stateless renders #63
- Made sure stateless renders are unmounted #63

## [0.1.0] - 2020-04-14
### Added
Expand Down
5 changes: 5 additions & 0 deletions examples/simple/.babelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"presets": [
"@babel/preset-react"
]
}
12 changes: 12 additions & 0 deletions examples/simple/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
<!DOCTYPE html>
<html>
<head>
<title>Crank.js Sandbox</title>
<meta charset="UTF-8" />
</head>

<body>
<div id="app"></div>
<script src="index.js"></script>
</body>
</html>
3 changes: 3 additions & 0 deletions examples/simple/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
// parcel keeps fucking importing regeneratorRuntime no matter what I put in browserlists so here we are
import "regenerator-runtime/runtime";
import "./src/index";
Loading