Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] (M300 Command Support) #241

Closed
Lmstaple opened this issue May 4, 2020 · 14 comments
Closed

[FR] (M300 Command Support) #241

Lmstaple opened this issue May 4, 2020 · 14 comments

Comments

@Lmstaple
Copy link

Lmstaple commented May 4, 2020

On the stock Creality board, as well as the silent creality board you could execute M300 commands after enabling the speaker in your configuration file.

Whether it is through the stock screen or the TFT35, no matter what I do I can not get any noise to sound when I enable the speaker in the config file.

I don't have much knowledge in terms of coding, but I wonder whether there is something missing that controls the speaker enabling in the greater Marlin folder, since there is sound with a buzzer but nothing with speaker, which should be on the same pins.

@HVJ17
Copy link

HVJ17 commented May 5, 2020

Speaker is disabled in Btt fw.

@Lmstaple
Copy link
Author

I understand it is disabled by default. I reference in the above comment that I have enabled it in my config file and flashed with no luck in getting any sound.

@HVJ17
Copy link

HVJ17 commented May 12, 2020

The SPEAKER is not usable through the mini 3e 1.2.

@Lmstaple
Copy link
Author

Lmstaple commented May 12, 2020 via email

@HVJ17
Copy link

HVJ17 commented May 12, 2020

I cannot. This is a hardware choice they made. I've not seen anyone able to get it working through Marlin.

@bigtreetech
Copy link
Owner

Hello, after this PR rogerclarkmelbourne/Arduino_STM32#796, speaker in stm32f1 should work normal (including SKR-mini-E3-V1.0/V1.2/V2.0, E3-DIP-V1.0, mini-V1.1, etc...), you need to delete the maple library for stm32f1 in "C:\Users<your usr name>.platformio\packages\framework-arduinoststm32-maple" (delete this folder), enable SPEAKER in Marlin's configuration.h, Then compile again, vscode will download the latest maple dependency library automatic, compile and update, and M300 should work normally

@Lmstaple
Copy link
Author

Lmstaple commented Jun 4, 2020

I am not sure if I am doing something incorrect, but when I deleted the Maple Library and built the firmware it now results in no noise across touchscreen mode and LCD mode. It does not register M300 commands nor does it recognize the typical clicking noise that accompanies using the knob on the LCD mode.

I have enabled the speaker, as well as the LCD Feedback frequency with it at default values.

Also, in the section directly below this I have the Cr-10 Display enabled. Do I need to change this?

@Lmstaple
Copy link
Author

Lmstaple commented Jun 4, 2020

Update: I went into the Tone.cpp and manually changed the TONE_CHANNEL 8 to TONE_CHANNEL 4 like was mentioned in one of the linked threads. I don't fully understand why it wasn't updated in the reinstall that I did upon building the firmware, but perhaps I was too impatient and it simply has not been made public yet?

Regardless, this fixed the issue, so I will be marking this closed. Thank you to everyone involved, can't wait to get my John Cena theme back lol.

@Lmstaple Lmstaple closed this as completed Jun 4, 2020
@jackharvest
Copy link

Tone.cpp and manually changed the TONE_CHANNEL 8 to TONE_CHANNEL 4

I don't see Tone.cpp when modifying the firmware for SKR mini 1.2. Where was this exactly?

@JdeV987
Copy link

JdeV987 commented Jun 24, 2020

Tone.cpp and manually changed the TONE_CHANNEL 8 to TONE_CHANNEL 4

I don't see Tone.cpp when modifying the firmware for SKR mini 1.2. Where was this exactly?

MarlinFirmware/Marlin#18011 (comment)

Also read this: MarlinFirmware/Marlin#18203

@jackharvest
Copy link

jackharvest commented Jun 24, 2020 via email

@bennymamo
Copy link

I have applied the fix to get "#define SPEAKER" working (changed file C:\Users\benny.platformio\packages\framework-arduinoststm32-maple\STM32F1\cores\maple\tone.cpp and changed TONE_CHANNEL from 8 to 4) and speaker works. Problem is that with this setup, Part cooling fan does not work correctly. Fan only starts when I enter some menu from LCD or similar action. To confirm that might be the issue, I reverted back changes and commented out SPEAKER and part fan is now working as it should. I will keep it without speaker. Buzzer is good enough for me. Thanks for the suggestion.

@trengtor
Copy link

Hello, after this PR rogerclarkmelbourne/Arduino_STM32#796, speaker in stm32f1 should work normal (including SKR-mini-E3-V1.0/V1.2/V2.0, E3-DIP-V1.0, mini-V1.1, etc...), you need to delete the maple library for stm32f1 in "C:\Users.platformio\packages\framework-arduinoststm32-maple" (delete this folder), enable SPEAKER in Marlin's configuration.h, Then compile again, vscode will download the latest maple dependency library automatic, compile and update, and M300 should work normally

Not working: compilation error instead auto library download

@yourbuddydinec
Copy link

By deleting framework-arduinoststm32-maple i was able to get the speaker to work but a single tone sounds repeated and for a long time so over and over. Anyone run into this problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants