Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up GitHub Actions for CI #63

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Conversation

botandrose
Copy link
Collaborator

@botandrose botandrose commented Oct 21, 2024

Hi @1cg, I've got something working here. Some notes:

  1. CI won't run in PRs (including this one) until the main branch has the CI action.
  2. So to prove that this PR does what it says it does, here's the same commit SHA running on my fork: https://github.com/botandrose/idiomorph/actions/runs/11441381562/job/31829306598
  3. This test run failed, but it looks to be an accurate state of the repo, because I'm seeing this exact same result when I run it locally.
  4. Once this is merged I'll write a follow-up PR getting CI green again.
  5. I had to pin Node to 16 because mocha-chrome doesnt work with 17+: Is this still maintained? shellscape/mocha-chrome#46 (comment) . mocha-chrome seems to be unmaintained, so I imagine we'll want to switch it out for something else, later.

@botandrose
Copy link
Collaborator Author

@1cg I've carved out some time in December to push on idiomorph, so ping on this so I can start submitting more PRs. I think it should be an easy review and merge.

@1cg
Copy link
Contributor

1cg commented Dec 2, 2024 via email

@botandrose
Copy link
Collaborator Author

botandrose commented Dec 2, 2024 via email

@1cg
Copy link
Contributor

1cg commented Dec 2, 2024 via email

@botandrose
Copy link
Collaborator Author

botandrose commented Dec 2, 2024 via email

@1cg 1cg merged commit d284d4d into bigskysoftware:main Dec 9, 2024
@botandrose botandrose deleted the github-actions branch December 9, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants