Distill BLOOM - tentative 2 #354
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
younesbelkada
commented
Oct 11, 2022
megatron/model/transformer.py
Outdated
| self.alibi = self.alibi.to(torch.bfloat16) | ||
| else: | ||
| self.alibi = None | ||
| @torch.no_grad() |
younesbelkada
commented
Oct 11, 2022
| @@ -30,6 +41,9 @@ def _get_params_for_weight_decay_optimization(modules): | |||
|
|
|||
| weight_decay_params = {'params': []} | |||
| no_weight_decay_params = {'params': [], 'weight_decay': 0.0} | |||
|
|
|||
| modules = _filter_for_teacher_student(modules) | |||
|
|
|||
| for module in modules: | |||
There was a problem hiding this comment.
Can we do the filtering on the for loop
- check before the fist if - if it is a Student module
- check also with
isinstanceinstead of class name
younesbelkada
commented
Oct 11, 2022
megatron/optimizer/__init__.py
Outdated
|
|
||
| for module in modules: | ||
| for module_ in module.modules(): | ||
| if "Student" in module_.__class__.__name__: |
younesbelkada
commented
Oct 13, 2022
| # transformer layer | ||
| if args.pp_partition_method is not None: | ||
| partition_method = args.pp_partition_method | ||
| else: | ||
| partition_method = 'type:transformer' | ||
|
|
||
|
|
||
| from deepspeed.runtime.pipe.topology import PipeModelDataParallelTopology |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tentative of applying teacher student using Megatron-DeepSpeed
WIP draft PR - not supposed to merge
cc @thomasw21