Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the get_leaves function and setup issues for Python 3.12 #404

Merged
merged 7 commits into from
Oct 7, 2024
Merged

Conversation

mmerce
Copy link
Member

@mmerce mmerce commented Oct 2, 2024

No description provided.

@mmerce mmerce requested a review from jaor October 2, 2024 21:58
Copy link
Member

@jaor jaor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good: a couple of nits below

docs/index.rst Outdated
`beautiful predictive models <https://bigml.com/gallery/models>`_ that
can be easily understood and interacted with.

These BigML Python bindings allow you to interact with BigML.io, the API
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allow you interacting

docs/index.rst Outdated

`BigML <https://bigml.com>`_ makes machine learning easy by taking care
of the details required to add data-driven decisions and predictive
power to your company. Unlike other machine learning services, BigML
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to your applications?

build:
os: ubuntu-22.04
tools:
python: "3.10"
python: "3.11"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not 3.12?

filter_function=filter_function)
else:
print("id:", node[offsets["id"]])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

debug leftover?

@jaor jaor merged commit 96c14bc into master Oct 7, 2024
5 checks passed
@jaor jaor deleted the leaves branch October 7, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants