Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup (sections 0 to 6) #36

Merged
merged 16 commits into from
Nov 21, 2019
Merged

cleanup (sections 0 to 6) #36

merged 16 commits into from
Nov 21, 2019

Conversation

RMeli
Copy link
Member

@RMeli RMeli commented Nov 20, 2019

Cleanup of sections 0 to 6:

  • Added comment on f-strings where string formatting was introduced (after the old comment about the new formatting method of Python 3)
    • Started converting to f-strings afterwards, where appropriate
  • Extensive use of inline code blocks instead of '' or ""(the correct symbol for a Markdown code block is ``)
  • Formatted links
  • Removed credits from first notebook since contributions are acknowledged in the README.md file
  • Increased header size for exercises

There is now a cleanup.sh script that removes notebook output. It's ideal to use it before commits, so that a pristine state of the notebook is ensured before committ (easier to version control).

Addresses:
#33

This was referenced Nov 20, 2019
Copy link
Collaborator

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple things, mainly for me to understand so that we have consistent header #s.

@RMeli
Copy link
Member Author

RMeli commented Nov 21, 2019

I think I addressed most of the issues. If this PR is ok, I'll do the same with the few remaining sections on my way back.

@IAlibay
Copy link
Collaborator

IAlibay commented Nov 21, 2019

lgtm! 👍

@IAlibay IAlibay merged commit 0c073ec into bigginlab:master Nov 21, 2019
@RMeli RMeli deleted the fixes branch November 21, 2019 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants