fix BAM/SAM header setting when writing on cluster #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test failure should be fixed. Jenkins, retest this please? |
|
Jenkins, retest this please |
| @@ -68,7 +68,7 @@ class IlluminaOptics(val tile: Long, val x: Long, val y: Long) {} | |||
|
|
|||
| class RichAlignmentRecord(val record: AlignmentRecord) { | |||
|
|
|||
| lazy val referenceLength: Int = RichAlignmentRecord.referenceLengthFromCigar(record.getCigar.toString) | |||
| lazy val referenceLength: Int = RichAlignmentRecord.referenceLengthFromCigar(record.getCigar) | |||
There was a problem hiding this comment.
Thanks for getting these; we've got several redundant toStrings hanging around from the pre-bdg-formats/36 merged.
fixes bigdatagenomics#676 - formatting / unnecessary `.toString` nits - one more header fix - whitespace nits
ryan-williams
force-pushed
the
sam-cluster
branch
from
2fd9af3 to
57447f8
Compare
|
rebased and squashed |
|
Jenkins, retest this please. |
|
|
Jenkins, retest this please. @ryan-williams that's a known issue in the Jenkins Github Pull Request Builder plugin. It occasionally fails to check out the PR after a force push to the branch. |
|
ah, good to know! I'll try to hold off the force-push-squash until after I've gotten a green build in the future. |
|
Jenkins, retest this please. |
fnothaft
added a commit
that referenced
this pull request
Jun 2, 2015
fix BAM/SAM header setting when writing on cluster
|
Merged! Thanks @ryan-williams! |
|
nice! thank you, @fnothaft! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #676