-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADAM-513] Remove ReferenceMappable trait. #592
[ADAM-513] Remove ReferenceMappable trait. #592
Conversation
Test PASSed. |
c404316
to
25624b7
Compare
Rebased. |
Test PASSed. |
Great work, @fnothaft! I'm happy to merge unless anyone has objections. |
@fnothaft, should we strip out the webapp folder in adam-cli/src/main/webapp? |
I like it too, although I'd (minor quibble) suggest that we could at least drop the VizReads and TrackedLayout stuff as a separate commit (if not a completely separate PR)? |
25624b7
to
4c700b8
Compare
Rebased following the #606 merge. |
Test PASSed. |
[ADAM-513] Remove ReferenceMappable trait.
Thanks, @fnothaft! Happy to see |
Resolves (?) #513. Removes the
ReferenceMappable
trait, along with theReferenceMappingContext
. Also strips out the visualization code; @erictu will be moving this into a downstream repository.