a few tweaks to scripts/jenkins-test #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
while debugging jenkins-test runs, I copied some of the files it generates into my local ADAM_HOME; these were in turn getting copied into the tmp dir created by jenkins-test, and causing various commands to fail when they realized the path they were trying to output to already exists. This seems like an unnecessary failure mode for the jenkins-test script to be vulnerable to (namely, the existence in local ADAM_HOME of files (untracked by git) with the same names as arbitrary paths that jenkins-test expects to write to), especially since these particular files are involved in tests but don’t actually live in the git repo.
|
Test PASSed. |
massie
added a commit
that referenced
this pull request
Nov 4, 2014
a few tweaks to scripts/jenkins-test
|
Thanks, Ryan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.