Allow retrying on failure for HTTPRangedByteAccess #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -19,24 +19,41 @@ package org.bdgenomics.adam.io | |||
|
|
|||
| import java.io.InputStream | |||
| import java.net.URI | |||
| import org.apache.http.{ HttpResponse, Header } | |||
| import org.apache.http.client.HttpClient | |||
| import org.apache.http.client.methods.{ HttpGet, HttpHead } | |||
| import org.apache.http.impl.client.DefaultHttpClient | |||
| import org.apache.spark.Logging | |||
|
|
|||
|
@carlyeks can you rebase this? |
|
Sad face...Probably need to try something else... |
|
Move the test files to S3? Let's not close this though, it's still a useful contribution. |
|
Jenkins, test this please. |
|
@carlyeks pinging here, can you rebase this and push the change with the berkeley/s3 URLs swapped then let's get this merged. |
|
@carlyeks pinging here again... any updates/an ETA? |
|
Ping @carlyeks |
fnothaft
added a commit
that referenced
this pull request
Aug 20, 2014
Allow retrying on failure for HTTPRangedByteAccess
|
Merged! Thanks @carlyeks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pushes the retry logic down into HTTPRangedByteAccess instead of in the tests; this allows us to also use this in the ParquetRDD class.