Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-2059] Properly pass back primitive typed arrays to HTSJDK. #2075

Merged
merged 1 commit into from
Nov 5, 2018

Conversation

heuermh
Copy link
Member

@heuermh heuermh commented Oct 28, 2018

Fixes #2059

Alt pull request to #2061, cherry-picked on top of #2072 and fixed unit test.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2845/

Build result: FAILURE

GitHub pull request #2075 of commit 6682107 automatically merged.Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos spark-test) in workspace /home/jenkins/workspace/ADAM-prbWiping out workspace first.Cloning the remote Git repositoryCloning repository https://github.com/bigdatagenomics/adam.git > git init /home/jenkins/workspace/ADAM-prb # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/heads/:refs/remotes/origin/ # timeout=15 > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10 > git config --add remote.origin.fetch +refs/heads/:refs/remotes/origin/ # timeout=10 > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ # timeout=15 > git rev-parse origin/pr/2075/merge^{commit} # timeout=10 > git branch -a -v --no-abbrev --contains 9c5fcc7 # timeout=10Checking out Revision 9c5fcc7 (origin/pr/2075/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f 9c5fcc7dbb7cda20f8716be5c20e9410453bb92aFirst time build. Skipping changelog.Triggering ADAM-prb ? 2.7.5,2.11,2.2.2,ubuntuADAM-prb ? 2.7.5,2.11,2.2.2,ubuntu completed with result FAILURENotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

@coveralls
Copy link

coveralls commented Oct 28, 2018

Coverage Status

Coverage increased (+0.06%) to 79.206% when pulling bd9da4a on heuermh:alt-issue-2059 into f3ec463 on bigdatagenomics:master.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2846/
Test PASSed.

@heuermh heuermh added this to the 0.25.0 milestone Nov 5, 2018
@heuermh
Copy link
Member Author

heuermh commented Nov 5, 2018

@akmorrow13 Ping for merge after Jenkins build completes

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2848/
Test PASSed.

@akmorrow13 akmorrow13 merged commit 55a8b3d into bigdatagenomics:master Nov 5, 2018
@akmorrow13
Copy link
Contributor

Thanks @heuermh!

@heuermh heuermh deleted the alt-issue-2059 branch November 7, 2018 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arrays should be passed to HTSJDK in the JVM primitive type
4 participants