Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADAM-1939] Allow validation stringency to waive off FLAG arrays. #1940

Merged
merged 1 commit into from
Mar 7, 2018
Merged

[ADAM-1939] Allow validation stringency to waive off FLAG arrays. #1940

merged 1 commit into from
Mar 7, 2018

Conversation

fnothaft
Copy link
Member

@fnothaft fnothaft commented Mar 7, 2018

Resolves #1939.

@fnothaft fnothaft added this to the 0.24.0 milestone Mar 7, 2018
@fnothaft fnothaft requested a review from heuermh March 7, 2018 01:12
@coveralls
Copy link

coveralls commented Mar 7, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.07%) to 82.532% when pulling 93b2510 on fnothaft:issues/1939-info-flag into f616784 on bigdatagenomics:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 82.545% when pulling 7a7eae6 on fnothaft:issues/1939-info-flag into 4e773c5 on bigdatagenomics:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 82.545% when pulling 7a7eae6 on fnothaft:issues/1939-info-flag into 4e773c5 on bigdatagenomics:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 82.545% when pulling 7a7eae6 on fnothaft:issues/1939-info-flag into 4e773c5 on bigdatagenomics:master.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2698/
Test PASSed.

heuermh
heuermh requested changes Mar 7, 2018
View reviewed changes
adam-core/src/test/scala/org/bdgenomics/adam/rdd/ADAMContextSuite.scala Outdated
@@ -482,14 +489,14 @@ class ADAMContextSuite extends ADAMFunSuite {
sparkTest("load vcf with a glob") {
val path = testFile("bqsr1.vcf").replace("bqsr1", "*")

val vcs = sc.loadVcf(path)
val vcs = sc.loadVcf(path, stringency = ValidationStringency.LENIENT)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to be a pain, could test files that are invalid be moved to a subdirectory so that the glob doesn't pick them up?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, SGTM

@fnothaft fnothaft force-pushed the issues/1939-info-flag branch from 7a7eae6 to 93b2510 Compare March 7, 2018 07:20
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2700/
Test PASSed.

@heuermh heuermh merged commit bc8c6f4 into bigdatagenomics:master Mar 7, 2018
@heuermh
Copy link
Member

heuermh commented Mar 7, 2018

Thank you, @fnothaft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heuermh heuermh heuermh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@fnothaft @coveralls @AmplabJenkins @heuermh