VariantContext converter refactor #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All automated tests passed. |
| } | ||
| private def attrAsString(attr: Object):Object = attr match { | ||
| case a: String => a | ||
| case a: java.util.List[String] => a(0) |
There was a problem hiding this comment.
I had a question RE: this line in #175.
|
This should merge before #173, correct? |
|
From the comments in the other one, I fixed braces and removed the array to string conversion |
|
Excellent! If you can squash this down, I think it is ready to merge. |
|
All automated tests passed. |
fnothaft
added a commit
that referenced
this pull request
Mar 17, 2014
VariantContext converter refactor
|
Merged! Thanks @arahuja! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR doesn't add any new functionality but just some cleanup/refactor on VariantContextConverter. This is a precursor of PR #173, but I pulled it out separately.