update to _replaceRdd with tests #1749
Conversation
|
Test FAILed. Build result: FAILURE[...truncated 15 lines...] > /home/jenkins/git2/bin/git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ # timeout=15 > /home/jenkins/git2/bin/git rev-parse origin/pr/1749/merge^{commit} # timeout=10 > /home/jenkins/git2/bin/git branch -a -v --no-abbrev --contains 3e638b5b1b55dfaa8062aad2e879745f06f1e1b0 # timeout=10Checking out Revision 3e638b5b1b55dfaa8062aad2e879745f06f1e1b0 (origin/pr/1749/merge) > /home/jenkins/git2/bin/git config core.sparsecheckout # timeout=10 > /home/jenkins/git2/bin/git checkout -f 3e638b5b1b55dfaa8062aad2e879745f06f1e1b0First time build. Skipping changelog.Triggering ADAM-prb ? 2.6.2,2.11,1.6.3,centosTriggering ADAM-prb ? 2.7.3,2.11,1.6.3,centosTriggering ADAM-prb ? 2.7.3,2.11,2.2.0,centosTriggering ADAM-prb ? 2.7.3,2.10,1.6.3,centosTriggering ADAM-prb ? 2.6.2,2.10,1.6.3,centosTriggering ADAM-prb ? 2.6.2,2.10,2.2.0,centosTriggering ADAM-prb ? 2.7.3,2.10,2.2.0,centosTriggering ADAM-prb ? 2.6.2,2.11,2.2.0,centosADAM-prb ? 2.6.2,2.11,1.6.3,centos completed with result SUCCESSADAM-prb ? 2.7.3,2.11,1.6.3,centos completed with result SUCCESSADAM-prb ? 2.7.3,2.11,2.2.0,centos completed with result FAILUREADAM-prb ? 2.7.3,2.10,1.6.3,centos completed with result SUCCESSADAM-prb ? 2.6.2,2.10,1.6.3,centos completed with result FAILUREADAM-prb ? 2.6.2,2.10,2.2.0,centos completed with result SUCCESSADAM-prb ? 2.7.3,2.10,2.2.0,centos completed with result SUCCESSADAM-prb ? 2.6.2,2.11,2.2.0,centos completed with result FAILURENotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'Test FAILed. |
|
Test PASSed. |
akmorrow13
force-pushed
the
python-fixes
branch
from
27c9a1a to
eec00a5
Compare
|
Test PASSed. |
| @@ -692,6 +692,11 @@ def _inferConversionFn(self, destClass): | |||
| class FeatureRDD(GenomicDataset): | |||
|
|
|||
|
|
|||
| def _replaceRdd(self, newRdd): | |||
There was a problem hiding this comment.
Is this only necessary in class FeatureRDD?
There was a problem hiding this comment.
@heuermh if it is not present transform will fail (_replaceRdd is not a function)
There was a problem hiding this comment.
https://github.com/akmorrow13/adam/blob/eec00a545dca3e4cd4e258023c99a1afa8a8974e/adam-python/bdgenomics/adam/rdd.py#L104 is defined in GenomicRDD, calling _replaceRDD, which FeatureRDD does not have
| @@ -692,6 +692,11 @@ def _inferConversionFn(self, destClass): | |||
| class FeatureRDD(GenomicDataset): | |||
|
|
|||
|
|
|||
| def _replaceRdd(self, newRdd): | |||
|
Thank you, @akmorrow13 |
No description provided.