Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADAM-1490] Add asSingleFile to saveAsFastq and related. #1621

Merged
merged 2 commits into from
Jul 22, 2017
Merged

[ADAM-1490] Add asSingleFile to saveAsFastq and related. #1621

merged 2 commits into from
Jul 22, 2017

Conversation

heuermh
Copy link
Member

@heuermh heuermh commented Jul 21, 2017

Fixes #1490

@coveralls
Copy link

coveralls commented Jul 21, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.5%) to 84.755% when pulling 8e4fee8 on heuermh:single-file-save into 640c44b on bigdatagenomics:master.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2263/
Test PASSed.

fnothaft
fnothaft requested changes Jul 21, 2017
View reviewed changes
Copy link
Member

@fnothaft fnothaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but can you plumb this through to maybeSaveFastq as well?

@heuermh heuermh modified the milestone: 0.23.0 Jul 22, 2017
@coveralls
Copy link

coveralls commented Jul 22, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.3%) to 83.961% when pulling fb87980 on heuermh:single-file-save into 640c44b on bigdatagenomics:master.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2272/
Test PASSed.

@fnothaft fnothaft merged commit d9b531c into bigdatagenomics:master Jul 22, 2017
@fnothaft
Copy link
Member

Merged! Thanks @heuermh!

@heuermh heuermh deleted the single-file-save branch July 22, 2017 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fnothaft fnothaft fnothaft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.
4 participants
@heuermh @coveralls @AmplabJenkins @fnothaft