Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADAM-1438] Add ability to save FASTA back as a single file. #1581

Merged
merged 1 commit into from
Jul 11, 2017
Merged

[ADAM-1438] Add ability to save FASTA back as a single file. #1581

merged 1 commit into from
Jul 11, 2017

Conversation

fnothaft
Copy link
Member

Resolves #1438. To support saving FASTA as a single file, moved the private writeTextRdd method from the FeatureRDD to GenomicRDD, and opened protections to protected.

@fnothaft fnothaft added this to the 0.23.0 milestone Jun 26, 2017
@coveralls
Copy link

coveralls commented Jun 26, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.06%) to 83.11% when pulling 18c12e8 on fnothaft:issues/1438-as-single-fasta into 0306717 on bigdatagenomics:master.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2149/
Test PASSed.

@heuermh
Copy link
Member

heuermh commented Jun 26, 2017

FYI, some of this was done already in #1505, which has been hanging around a while because GenomicRDD keeps changing.

@fnothaft
[ADAM-1438] Add ability to save FASTA back as a single file.
2ebac20 
Resolves bigdatagenomics#1438. To support saving FASTA as a single file, moved the
private `writeTextRdd` method from the `FeatureRDD` to `GenomicRDD`, and opened
protections to `protected`.
@fnothaft fnothaft force-pushed the issues/1438-as-single-fasta branch from 18c12e8 to 2ebac20 Compare July 11, 2017 04:01
@fnothaft
Copy link
Member Author

Rebased.

@coveralls
Copy link

coveralls commented Jul 11, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 84.153% when pulling 2ebac20 on fnothaft:issues/1438-as-single-fasta into 97a8498 on bigdatagenomics:master.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2194/
Test PASSed.

@heuermh heuermh merged commit 467db1f into bigdatagenomics:master Jul 11, 2017
@heuermh
Copy link
Member

heuermh commented Jul 11, 2017

Thank you, @fnothaft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heuermh heuermh heuermh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.
4 participants
@fnothaft @coveralls @AmplabJenkins @heuermh