[ADAM-1038] Eliminate writing to /tmp during CI builds. #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
fnothaft
force-pushed
the
issues/1038-set-tempdir
branch
from
b1e7f74 to
6e28504
Compare
Resolves bigdatagenomics#1038. When running `scripts/jenkins-test`, we make a temp dir where all test files are written. We modify our `pom.xml`s at test time so that this temp dir is passed as `java.io.tmpdir` when running scalatest, and then clean the temp dir at the end of the CI build.
|
Test PASSed. |
|
LGTM, works locally |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1038. When running
scripts/jenkins-test, we make a temp dir where all test files are written. We modify ourpom.xmls at test time so that this temp dir is passed asjava.io.tmpdirwhen running scalatest, and then clean the temp dir at the end of the CI build.CC @shaneknapp