Extended TwoBitFile and NucleotideContigFragmentRDDFunctions to behave more similar #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
akmorrow13
commented
Jul 13, 2016
akmorrow13
commented
- Extended NucleotideContigFragmentRDDFunctions to ReferenceFile
- Added getSequenceDictionary function to TwoBitFile
|
Test FAILed. Build result: FAILUREGitHub pull request #1079 of commit e035ee9 automatically merged.Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos spark-test) in workspace /home/jenkins/workspace/ADAM-prb > /home/jenkins/git2/bin/git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > /home/jenkins/git2/bin/git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > /home/jenkins/git2/bin/git --version # timeout=10 > /home/jenkins/git2/bin/git -c core.askpass=true fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ # timeout=15 > /home/jenkins/git2/bin/git rev-parse origin/pr/1079/merge^{commit} # timeout=10 > /home/jenkins/git2/bin/git branch -a --contains 1084b30 # timeout=10 > /home/jenkins/git2/bin/git rev-parse remotes/origin/pr/1079/merge^{commit} # timeout=10Checking out Revision 1084b30 (origin/pr/1079/merge) > /home/jenkins/git2/bin/git config core.sparsecheckout # timeout=10 > /home/jenkins/git2/bin/git checkout -f 1084b305f73d732332930a9109f54a75be4956bbFirst time build. Skipping changelog.Triggering ADAM-prb ? 2.6.0,2.11,1.5.2,centosTriggering ADAM-prb ? 2.6.0,2.10,1.5.2,centosTouchstone configurations resulted in FAILURE, so aborting...Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'Test FAILed. |
|
@akmorrow13 let's chat about this sometime. |
| def getSequenceDictionary(performLexSort: Boolean = false): SequenceDictionary = { | ||
| val sd = new SequenceDictionary(seqRecords.toVector.map(r => SequenceRecord(r._1, r._2.dnaSize))) | ||
|
|
||
| if (performLexSort) { |
There was a problem hiding this comment.
I need the sequence dictionary from 2 bit file. Is there a better way to get it?
There was a problem hiding this comment.
Oh, yeah, that makes sense. My comment was with regards to the lexicographic sort.
There was a problem hiding this comment.
IIRC, we've added lex sort functions to the SequenceDictionary, so I'd rather not dupe the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.