Refactoring org.bdgenomics.adam.io package.
#1064
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
| * and the quality encoding includes '@' in its valid character range. So how should one | ||
| * distinguish between \n@ as a record delimiter and and \n@ as part of a multi-line | ||
| * quality string? | ||
| * |
* Added documentation to all classes, methods, and fields that were missing descriptions. * Factored duplicated code from `SingleFastqRecordReader` and `InterleavedFastqRecordReader` out into a new abstract base class `FastqRecordReader`. * Tightened up access modifiers where possible. Sadly, the two input formats cannot be made more private, since Java has a more restricted form of package-private than scala, and the input formats are used from inside of `org.bdgenomics.adam.rdd`. * Removed `@author` tags.
|
Addressed review comments. |
|
Test PASSed. |
|
Test PASSed. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SingleFastqRecordReaderandInterleavedFastqRecordReaderout into a new abstract base classFastqRecordReader.org.bdgenomics.adam.rdd.@authortags.