Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace jvmRdd with jvmDataset in adam-python #2134

Closed
akmorrow13 opened this issue Mar 6, 2019 · 6 comments · Fixed by #2296
Closed

Replace jvmRdd with jvmDataset in adam-python #2134

akmorrow13 opened this issue Mar 6, 2019 · 6 comments · Fixed by #2296
Milestone
0.34.0

Comments

@akmorrow13
Copy link
Contributor

https://github.com/bigdatagenomics/adam/blob/master/adam-python/bdgenomics/adam/rdd.py#L53 and elsewhere should be called jvmDataset
@heuermh
Copy link
Member

heuermh commented Mar 6, 2019

Python needs types! What is jvmRdd an instance of?

@akmorrow13
Copy link
Contributor Author

jvmRdd is actually a jvmDataset, but it is still called jvmRdd, which is confusing

@heuermh
Copy link
Member

heuermh commented Mar 14, 2019

Yeah but what type? adam.rdd.GenomicDataset or Spark Dataset?

@akmorrow13
Copy link
Contributor Author

I think adam.rdd.GenomicDataset

@heuermh
Copy link
Member

heuermh commented Mar 14, 2019 •
edited
Loading

Yeah there are some magick conversions going on in there and I'm not wholly confident I know what is happening.

Perhaps this change could be part of the mess I am making in #2112.

@heuermh heuermh added this to the 0.34.0 milestone Jan 28, 2021
@heuermh
Copy link
Member

heuermh commented Jan 28, 2021

Trying again in #2296

@heuermh heuermh mentioned this issue Feb 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.34.0
Development

Successfully merging a pull request may close this issue.

[ADAM-2112] Refactor org.bdgenomics.adam.rdd package to org.bdgenomics.adam.ds heuermh/adam
2 participants
@heuermh @akmorrow13