fix(storefront): bctheme-1145 enable using external lib for templates under organization #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jairo-bc
reviewed
Jul 5, 2022
| @@ -168,7 +168,11 @@ class Bundle { | |||
|
|
|||
| if (!externalTemplatesImports) return []; | |||
|
|
|||
| return externalTemplatesImports.map((templateImport) => templateImport.split('/')[1]); | |||
| return externalTemplatesImports.map((templateImport) => { | |||
There was a problem hiding this comment.
What do you think if it's possible to get some test coverage on this function?
… under organization
bc-alexsaiannyi
force-pushed
the
bctheme-1145
branch
from
9f96c64
to
8aa07af
Compare
jairo-bc
approved these changes
Jul 13, 2022
yurytut1993
approved these changes
Jul 13, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
While working on themes-ui-components library with UI components we've found that it will prevent from successful running stencil bundle since we use it under bigcommerce organization name. This PR addresses this issue and enables to work with external libs within different organization.
Tickets / Documentation
Screenshots (if appropriate)
cc @bigcommerce/storefront-team