fix: strf-6383 add check for template size #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattolson
reviewed
May 28, 2019
junedkazi
reviewed
May 28, 2019
|
No changelog for cli it is auto generated on release. |
mattolson
approved these changes
May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Description
We need to validate the size of generated parsed/templates and make sure each of them are under 1MB.
We should fail the bundle process and notify on the terminal which generated files are greater than 1MB.
We are seeing a bunch of cases where zip files are under 50MB but the uploads still fail due to generated parsed/templates files greater than 1MB.
Tickets / Documentation
Add links to any relevant tickets and documentation.
https://jira.bigcommerce.com/browse/STRF-6383