Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STRF-4472 - Allow forward slash in store url #369

Merged
merged 1 commit into from
Feb 21, 2018
Merged

STRF-4472 - Allow forward slash in store url #369

merged 1 commit into from
Feb 21, 2018

Conversation

mjschock
Copy link
Contributor

What?

  • replaces a slash if present at the end of the store url so it's allowed and doesn't throw an error

Tickets / Documentation

Screenshots

  • before

screen shot 2018-02-20 at 4 08 25 pm

  • after

screen shot 2018-02-20 at 4 07 53 pm

@bigcommerce/storefront-team

@bookernath
Copy link
Contributor

@mjschock idea - why not be even more permissive and accept basically any URL regardless of path, query string, etc? I did this recently for archer - https://github.com/bigcommerce-labs/archer/pull/44

@mjschock
Copy link
Contributor Author

@bookernath 👍 i've made it more permissive, now all of these are okay:

http://example.com
https://example.com
example.com

http://example.com/
https://example.com/
example.com/

http://example.com/blah/
https://example.com/blah/
example.com/blah/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants